fix(polish-summaries): Batch API custom_id charset (hash ids, path in feature)#91
Merged
Merged
Conversation
…n feature
First live run 400'd: custom_id must match ^[a-zA-Z0-9_-]{1,64}$ and
'sum__cli/concept.md' doesn't. custom_id becomes sum_<sha256[:24]>;
the readable rel path rides in the request/result 'feature' field and
apply_results maps through that instead of parsing the id. Regression
test pins the charset.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
silversurfer562
added a commit
that referenced
this pull request
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First live run of
polish-summaries400'd at submit: the Batch API enforces^[a-zA-Z0-9_-]{1,64}$oncustom_id, and the path-basedsum__cli/concept.mdviolates it (slash + dot). Nowsum_<sha256(path)[:24]>, with the readable path carried in the request/resultfeaturefield —apply_resultsmaps through that, never by parsing the id. Charset regression test added. Suite 1250 green.🤖 Generated with Claude Code